Add start and end of string anchors to identifier regex in cdl.md #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is super minor, of course, but I think the caret helps folks understand the significance of `[$A-Za-z_]` specifically representing the starting character of the identifier name. And when one anchors the start of a string, one should also anchor the end :-) Feel free to reject and call me out as a fool :-)
|
@stewsk Any objections? |
stewsk
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is super minor, of course, but I think the caret helps folks understand the significance of
[$A-Za-z_]specifically representing the starting character of the identifier name. And when one anchors the start of a string, one should also anchor the end :-)Feel free to reject and call me out as a fool :-)